Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Chromium/WebKit bugs for selectionchange events #16358

Merged
merged 1 commit into from
May 21, 2022
Merged

Link Chromium/WebKit bugs for selectionchange events #16358

merged 1 commit into from
May 21, 2022

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented May 19, 2022

No description provided.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 19, 2022
@foolip
Copy link
Collaborator Author

foolip commented May 19, 2022

@tkent-google FYI, this is why I asked about a bug in w3c/selection-api#141.

@saschanaz
Copy link
Contributor

Should it say the event directly goes to document without bubbling on those browsers? (Try data:text/html,<body onselectionchange="console.log(event)"><input onselectionchange="console.log(event)">)

@foolip
Copy link
Collaborator Author

foolip commented May 20, 2022

That's a good idea, yes! How about this note?

A selectionchange event is fired on document, see Document's selectionchange event. See bug 1234 for firing the event on <input> elements.

@saschanaz
Copy link
Contributor

Looks good to me 👍

@queengooborg queengooborg merged commit 8168939 into mdn:main May 21, 2022
@saschanaz
Copy link
Contributor

saschanaz commented May 21, 2022 •
edited
Loading

Well, we haven't added the notes in #16358 (comment)...

@queengooborg
Copy link
Collaborator

Ah my bad, I didn't see the thread before...

@saschanaz
Copy link
Contributor

Mind opening a new PR?

@foolip foolip deleted the selectionchange-bugs branch May 23, 2022 07:01
@foolip
Copy link
Collaborator Author

foolip commented May 23, 2022

@queengooborg I couldn't see any open PR from you, so I rolled the changes into #16359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foolip @saschanaz @queengooborg